ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1634760209
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -147,6 +175,42 @@ static Snapshot fromJson(JsonNode node) {
if (node.has(MANIFEST_LIST)) {
// the manifest list is stored in a manifest list file
String manifestList = JsonUtil.getString(MANIFEST_LIST, node);
+
+ ByteBuffer manifestListKeyMetadata = null;
+ ByteBuffer wrappedManifestListKeyMetadata = null;
+ String wrappedKeyEncryptionKey = null;
Review Comment:
They are used later, in the BaseSnapshot constructor. We can use a different
constructor (if no manifest list encryption), but the code won't be more
compact.
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -162,6 +162,16 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io)
{
*/
String manifestListLocation();
Review Comment:
@rdblue @RussellSpitzer what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
