ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1634747442
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -93,6 +102,21 @@ static void toJson(Snapshot snapshot, JsonGenerator
generator) throws IOExceptio
generator.writeNumberField(SCHEMA_ID, snapshot.schemaId());
}
+ if (snapshot.manifestListFile().wrappedKeyMetadata() != null) {
+ generator.writeStringField(
+ MANIFEST_LIST_KEY_METADATA,
snapshot.manifestListFile().wrappedKeyMetadata());
+ ByteBuffer decodedManifestListKeyMetadata =
+ ByteBuffer.wrap(
+
Base64.getDecoder().decode(snapshot.manifestListFile().wrappedKeyMetadata()));
+
+ NativeEncryptionKeyMetadata wrappedKeyMetadata =
Review Comment:
Good catch. I'll remove these lines.
##########
api/src/main/java/org/apache/iceberg/ManifestListFile.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import java.io.Serializable;
+
+public class ManifestListFile implements Serializable {
+ private final String location;
+ private final String wrappedKeyMetadata;
+ private final long size;
+ private final String wrappedKeyEncryptionKey;
+
+ public ManifestListFile(
+ String location, String wrappedKeyMetadata, long size, String
wrappedKeyEncryptionKey) {
+ this.location = location;
+ this.wrappedKeyMetadata = wrappedKeyMetadata;
+ this.size = size;
+ this.wrappedKeyEncryptionKey = wrappedKeyEncryptionKey;
+ }
+
+ /** Location of manifest list file. */
+ public String location() {
+ return location;
+ }
+
+ /**
+ * Key metadata for manifest list in encrypted table.
+ *
+ * @return encrypted and base64-encoded key metadata for the manifest list
file
+ */
+ public String wrappedKeyMetadata() {
+ return wrappedKeyMetadata;
+ }
+
+ /**
+ * In encrypted tables, return the size of manifest list file. Must be a
verified value, taken
+ * from a trusted source. In unencrypted tables, can return 0.
+ */
+ public long size() {
+ return size;
+ }
+
+ public String wrappedKeyEncryptionKey() {
Review Comment:
Add javadoc: "Manifest list keys are encrypted with a table "key encryption
key". This function returns a KMS wrap of the key encryption key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
