danielcweeks commented on code in PR #10433: URL: https://github.com/apache/iceberg/pull/10433#discussion_r1625018098
########## api/src/main/java/org/apache/iceberg/io/RetryableInputStream.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io; + +import dev.failsafe.Failsafe; +import dev.failsafe.RetryPolicy; +import dev.failsafe.RetryPolicyBuilder; +import java.io.IOException; +import java.io.InputStream; +import java.net.SocketTimeoutException; +import java.time.Duration; +import java.util.List; +import java.util.function.Supplier; +import javax.net.ssl.SSLException; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +/** + * RetryableInputStream wraps over an underlying InputStream and retries failures encountered when + * reading through the stream. On retries, the underlying streams will be reinitialized. + */ +public class RetryableInputStream extends InputStream { + + private final InputStream underlyingStream; + private final RetryPolicy<Object> retryPolicy; + + private RetryableInputStream(InputStream underlyingStream, RetryPolicy<Object> retryPolicy) { + this.underlyingStream = underlyingStream; + this.retryPolicy = retryPolicy; + } + + @Override + public int read() throws IOException { + return Failsafe.with(retryPolicy).get(() -> underlyingStream.read()); + } + + @Override + public int read(byte[] b, int off, int len) throws IOException { + return Failsafe.with(retryPolicy).get(() -> underlyingStream.read(b, off, len)); + } + + @Override + public void close() throws IOException { + underlyingStream.close(); + } + + public static RetryableInputStream.Builder builderFor(Supplier<InputStream> newStreamSupplier) { + return new Builder(newStreamSupplier); + } + + public static class Builder { + + private InputStream underlyingStream; + private final Supplier<InputStream> newStreamProvider; + private List<Class<? extends Exception>> retryableExceptions = + ImmutableList.of(SSLException.class, SocketTimeoutException.class); Review Comment: @singhpk234 I believe the SDK already handles 503 errors and other errors that happen during the initiation of the request. I believe output stream is different (I don't think we've heard of issues on that side), but I would handle that in a separate PR if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
