amogh-jahagirdar commented on code in PR #10433:
URL: https://github.com/apache/iceberg/pull/10433#discussion_r1624925629
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -139,7 +140,11 @@ private InputStream readRange(String range) {
S3RequestUtil.configureEncryption(s3FileIOProperties, requestBuilder);
- return s3.getObject(requestBuilder.build(),
ResponseTransformer.toInputStream());
+ stream =
+ RetryableInputStream.builderFor(
+ () -> s3.getObject(requestBuilder.build(),
ResponseTransformer.toInputStream()))
Review Comment:
any failures that occur on the retry during the getObject request (not the
stream read) should just be handled by the SDK. Don't think we need to add
anything custom for that since the S3 client is already pluggable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
