adutra commented on code in PR #10314:
URL: https://github.com/apache/iceberg/pull/10314#discussion_r1601403672
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -254,7 +254,6 @@ private static OAuthTokenResponse handleOAuthRequest(Object
body) {
case "client_credentials":
return OAuthTokenResponse.builder()
.withToken("client-credentials-token:sub=" +
request.get("client_id"))
-
.withIssuedTokenType("urn:ietf:params:oauth:token-type:access_token")
Review Comment:
I don't agree: this flow is not governed by RFC 8693, this is RFC 6749
section 4.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
