nastra commented on code in PR #10256:
URL: https://github.com/apache/iceberg/pull/10256#discussion_r1601172497
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -215,6 +215,12 @@ public void initialize(String name, Map<String, String>
unresolved) {
this.paths = ResourcePaths.forCatalogProperties(mergedProps);
String token = mergedProps.get(OAuth2Properties.TOKEN);
+ // re-resolve these variables in case they were overridden by the config
endpoint
+ credential = mergedProps.get(OAuth2Properties.CREDENTIAL);
Review Comment:
I don't think it's actually correct to send back a `credential` to the
client via the `config` endpoint. The client credential flow follows the OAuth2
Spec as defined [here](https://datatracker.ietf.org/doc/html/rfc6749#autoid-49)
(there's also a shorter example for this
[here](https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/))
and so sending back a client-controlled `credential` to the client doesn't feel
right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
