huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1580538348
########## gradle.properties: ########## @@ -20,8 +20,8 @@ systemProp.defaultFlinkVersions=1.18 systemProp.knownFlinkVersions=1.16,1.17,1.18 systemProp.defaultHiveVersions=2 systemProp.knownHiveVersions=2,3 -systemProp.defaultSparkVersions=3.5 Review Comment: Reverted ########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ########## @@ -196,6 +201,33 @@ private Duration toDuration(String time) { } } + class ReadTypeConfParser extends ConfParser<ReadTypeConfParser, ReaderType> { Review Comment: Thanks for the suggestion! Changed to `EnumConfParser` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org