amogh-jahagirdar commented on PR #10185: URL: https://github.com/apache/iceberg/pull/10185#issuecomment-2066942872
I don't really consider it a mistake to have the plural form. The exposed syntax and the actual metadata which is spec compliant are independent concerns. For the metadata we already know we're writing the spec compliant representation of the transform. For the syntax I believe we should optimize for user experience, and I think having both options available just makes it easier since it's easy for someone to punch in the plural form (with minimal code maintenance concerns). Put another way, I don't think the common user is trying to correlate and expect the exact thing in the metadata; they mostly would care that it's a good experience and that what is written to metadata is spec compliant IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
