aokolnychyi commented on code in PR #10128:
URL: https://github.com/apache/iceberg/pull/10128#discussion_r1567963497
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java:
##########
@@ -275,18 +275,20 @@ public Table alterTable(Identifier ident, TableChange...
changes) throws NoSuchT
@Override
public boolean dropTable(Identifier ident) {
- // no need to check table existence to determine which catalog to use. if
a table doesn't exist
Review Comment:
Based on what I see in the test case, I don't think the problem is in
`SparkSessionCatalog`. The primary issue is that our `HiveCatalog` may drop a
pointer without checking if it points to a valid Iceberg table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]