wForget commented on code in PR #10128:
URL: https://github.com/apache/iceberg/pull/10128#discussion_r1566943822
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java:
##########
@@ -275,18 +275,20 @@ public Table alterTable(Identifier ident, TableChange...
changes) throws NoSuchT
@Override
public boolean dropTable(Identifier ident) {
- // no need to check table existence to determine which catalog to use. if
a table doesn't exist
Review Comment:
> This PR requires tests that would show the exact problem that was faced
and how the new logic behaves now.
thanks, added new unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
