huaxingao commented on code in PR #10149:
URL: https://github.com/apache/iceberg/pull/10149#discussion_r1566594959
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -167,6 +167,10 @@ private TableProperties() {}
"write.parquet.bloom-filter-max-bytes";
public static final int PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT = 1024 * 1024;
+ public static final String PARQUET_BLOOM_FILTER_COLUMN_FPP_PREFIX =
+ "write.parquet.bloom-filter-fpp.column.";
+ public static final double PARQUET_BLOOM_FILTER_COLUMN_FPP_DEFAULT = 0.01;
Review Comment:
@manuzhang Thanks for taking a look at my PR!
I scanned through `TableProperties`, and it seems that only the reserved
table properties have comments; the rest of the properties don't have any. I
will follow the same convention. We have the corresponding doc in
`configuration.md`.
I don't have a good way to test this. In my local test, I stepped into
[code](https://github.com/apache/parquet-mr/blob/parquet-1.13.x/parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java#L97)
to make sure that fpp can be set correctly using the config I added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
