aokolnychyi commented on code in PR #10149: URL: https://github.com/apache/iceberg/pull/10149#discussion_r1566414171
########## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ########## @@ -476,7 +493,10 @@ static Context dataContext(Map<String, String> config) { int bloomFilterMaxBytes = PropertyUtil.propertyAsInt( config, PARQUET_BLOOM_FILTER_MAX_BYTES, PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT); - Preconditions.checkArgument(bloomFilterMaxBytes > 0, "bloom Filter Max Bytes must be > 0"); Review Comment: Is this change relevant? If not, can we do it in a follow-up PR? We need to fix the docs as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org