aokolnychyi commented on code in PR #10123:
URL: https://github.com/apache/iceberg/pull/10123#discussion_r1566226747
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -43,6 +43,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (!addsDataFiles() && addsDeleteFiles()) {
Review Comment:
I believe `RewriteFiles` cannot be used for deletion. It must be used only
for rewrites when the input data is logically the same as produced data. The
operation should be "replace". It is important to preserve that since such
snapshots can be ignored when processing differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
