nastra commented on code in PR #10123:
URL: https://github.com/apache/iceberg/pull/10123#discussion_r1565536566


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -286,9 +288,13 @@ protected void validateProperty(Snapshot snapshot, String 
property, Set<String>
   }
 
   protected void validateProperty(Snapshot snapshot, String property, String 
expectedValue) {
-    String actual = snapshot.summary().get(property);
-    Assert.assertEquals(
-        "Snapshot property " + property + " has unexpected value.", 
expectedValue, actual);
+    if (null == expectedValue) {

Review Comment:
   these changes will show the content of the snapshot summary in case the 
assertion fails



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to