nastra commented on code in PR #10052:
URL: https://github.com/apache/iceberg/pull/10052#discussion_r1560539559
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -85,6 +87,8 @@ public class HTTPClient implements RESTClient {
private HTTPClient(
String uri,
+ HttpHost proxy,
+ CredentialsProvider credsProvider,
Review Comment:
I think this should be named `proxyCredentialsProvider` to clearly indicate
that this is only configured when the proxy is configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
