amogh-jahagirdar commented on code in PR #10052:
URL: https://github.com/apache/iceberg/pull/10052#discussion_r1543187257
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -493,7 +525,17 @@ public HTTPClient build() {
interceptor =
loadInterceptorDynamically(SIGV4_REQUEST_INTERCEPTOR_IMPL, properties);
}
- return new HTTPClient(uri, baseHeaders, mapper, interceptor, properties);
+ BasicCredentialsProvider credsProvider = null;
+
+ if (proxy != null && proxyUsername != null && proxyPassword != null) {
+ credsProvider = new BasicCredentialsProvider();
+ credsProvider.setCredentials(
+ new AuthScope(proxy),
+ new UsernamePasswordCredentials(proxyUsername,
proxyPassword.toCharArray()));
Review Comment:
If we make the API change I mentioned here
https://github.com/apache/iceberg/pull/10052/files#r1543172906, we would remove
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
