rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1558237579
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -564,6 +575,7 @@ private static String sanitizeDate(int days, int today) {
return "(date)";
}
+ // TODO(epg): `now` is millisecond resolution; shouldn't this be too?
Review Comment:
You can remove this comment because `now` is not in milliseconds. It is in
micros. Otherwise this wouldn't work. See lines 256 and 349.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
