rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1558234765
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -600,6 +612,12 @@ private static String sanitizeString(CharSequence value,
long now, int today) {
} else if (TIMESTAMPTZ.matcher(value).matches()) {
Literal<Long> ts =
Literal.of(value).to(Types.TimestampType.withZone());
return sanitizeTimestamp(ts.value(), now);
+ } else if (TIMESTAMPNS.matcher(value).matches()) {
Review Comment:
Is this code path used? The `TIMESTAMP` and `TIMESTAMPTZ` patterns match
`\d{1,9}` and are checked first. I think those will likely match anything that
these would match before checking the nanosecond patterns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
