cccs-jc commented on issue #10029: URL: https://github.com/apache/iceberg/issues/10029#issuecomment-2020343574
@amogh-jahagirdar I'm going to apply this patch to our internal deployment of Iceberg 1.5 and will likely run with it for a while. At the same time I will create a PR to the main branch of the official Iceberg repo. I agree this needs good testing. I have started writing unit tests specifically for this. Luckily I did not have to modify the metrics, dictionary and bloom visitor too much. The biggest change is in the way these are combined. @huaxingao @RussellSpitzer @zhongyujiang are we in agreement with this approach taken in this patch https://github.com/CybercentreCanada/iceberg/tree/parquet_column_eval. I think this is a substantial improvement over the current implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
