huaxingao commented on issue #10029: URL: https://github.com/apache/iceberg/issues/10029#issuecomment-2016577139
@cccs-jc Thanks for your proposal! For filter `col1=1 || col2=1`, the current implementation is: ``` shouldRead = statsFilter(col1=1 || col2=1) && dictFilter(col1=1 || col2=1) && bloomFilter(col1=1 || col2=1) ``` Your suggested modification appears to be: ``` shouldRead = (statsFilter(col1) && dictFilter(col1=1) && bloomFilter(col1=1)) || (statsFilter(col2) && dictFilter(col1=2) && bloomFilter(col1=2)) ``` This approach seems logically sound. However, the change you proposed may require modifications to the current predicate evaluation model. I suspect this could necessitate quite a few adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org