liurenjie1024 commented on code in PR #304:
URL: https://github.com/apache/iceberg-rust/pull/304#discussion_r1538836003
##########
crates/catalog/glue/src/error.rs:
##########
@@ -15,15 +15,13 @@
// specific language governing permissions and limitations
// under the License.
-//! Iceberg Glue Catalog implementation.
-
use anyhow::anyhow;
use std::fmt::Debug;
use iceberg::{Error, ErrorKind};
/// Format AWS SDK error into iceberg error
-pub fn from_aws_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
+pub fn from_sdk_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
Review Comment:
```suggestion
pub fn from_aws_sdk_error<T>(error: aws_sdk_glue::error::SdkError<T>) ->
Error
```
##########
crates/catalog/glue/src/error.rs:
##########
@@ -15,15 +15,13 @@
// specific language governing permissions and limitations
// under the License.
-//! Iceberg Glue Catalog implementation.
-
use anyhow::anyhow;
use std::fmt::Debug;
use iceberg::{Error, ErrorKind};
/// Format AWS SDK error into iceberg error
-pub fn from_aws_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
+pub fn from_sdk_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
Review Comment:
How about implementing `From` trait to avoid these naming problem?
##########
crates/catalog/glue/src/error.rs:
##########
@@ -33,3 +31,12 @@ where
)
.with_source(anyhow!("aws sdk error: {:?}", error))
}
+
+/// Format AWS Build error into iceberg error
+pub fn from_build_error(error: aws_sdk_glue::error::BuildError) -> Error {
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
