haizhou-zhao commented on code in PR #9838:
URL: https://github.com/apache/iceberg/pull/9838#discussion_r1538384050
##########
open-api/rest-catalog-open-api.py:
##########
@@ -171,7 +171,6 @@ class SortOrder(BaseModel):
class Summary(BaseModel):
operation: Literal['append', 'replace', 'overwrite', 'delete']
- additionalProperties: Optional[str] = None
Review Comment:
When I used the plain OpenAPI generator (tested on 6.6.0 & 7.0.0) to
generate python code, this is what I got
```
...
class SnapshotSummary(BaseModel):
"""
SnapshotSummary
"""
operation: StrictStr = Field(...)
additional_properties: Dict[str, Any] = {}
__properties = ["operation"]
...
```
Which is closer to what you suggested above. I guess the code generation
process here might leverage some different library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
