dramaticlly commented on code in PR #9993:
URL: https://github.com/apache/iceberg/pull/9993#discussion_r1538353913


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -177,6 +177,15 @@ default boolean hasDeletedFiles() {
   /** Returns the total number of rows in all files with status DELETED in the 
manifest file. */
   Long deletedRowsCount();
 
+  /**
+   * Returns true if there are any added or existing files
+   *
+   * @return whether this manifest contains entries with ADDED and/or EXISTING
+   */
+  default boolean hasLiveFiles() {
+    return this.hasAddedFiles() || this.hasExistingFiles();

Review Comment:
   can probably drop `this` for consistency as it's not used for all methods in 
this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to