a-agmon commented on issue #299: URL: https://github.com/apache/iceberg-rust/issues/299#issuecomment-2017966111
> Hi, @a-agmon Thanks for raising this. Let me add some background here, the reason the field is named as `data_file` is that, in fact for each `FileScanTask` we have not only data file, but also deletion files, e.g. position deletes and eq delete files. Currently they are not included because the logic of applying and pruning deletion files is a little complicated, and we decided to focus on read only data first. > > > The other option, is to rename the data_file field on FileScanTask to manifest_entry whereas the data file fields will be accessed like: file_scan_task.manifest_entry().data_file().some_property > > This is reasonable to me, but I have a small suggestion to rename `data_file` to `data_manifest_entry`, what do you think? Sounds good. Will submit a PR for us to consider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
