liurenjie1024 commented on issue #299: URL: https://github.com/apache/iceberg-rust/issues/299#issuecomment-2017898293
> > This is reasonable to me, but I have a small suggestion to rename `data_file` to `data_manifest_entry`, what do you think? > > Can we not simply use `manifest_entry` instead of data_file and have the delete_file named explicitly like that, once we get there? I think this is how the java impl does it (I only took a quick look - so bear with me if I'm mistaken)? https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/FileScanTask.java Sorry I don't quite get your meaning, do you mean to use `manifest_entry` for data file, and `deletes` for deletions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
