nastra commented on code in PR #10002:
URL: https://github.com/apache/iceberg/pull/10002#discussion_r1530591056
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -66,6 +67,9 @@ class GlueTableOperations extends
BaseMetastoreTableOperations {
// same as org.apache.hadoop.hive.metastore.TableType.EXTERNAL_TABLE
// more details:
https://docs.aws.amazon.com/glue/latest/webapi/API_TableInput.html
private static final String GLUE_EXTERNAL_TABLE_TYPE = "EXTERNAL_TABLE";
+ private static final String GLUE_ICEBERG_METADATA_REFRESH_MAX_RETRIES =
+ "iceberg.glue.metadata-refresh-max-retries";
Review Comment:
because this seems like something that should be configurable not just for
Glue. Why can't we add a new property either to `BaseMetastoreTableOperations`
or to `TableProperties`. All places that currently call `void
refreshFromMetadataLocation(String newLocation)` would then read that property
(or default to 20) and call `void refreshFromMetadataLocation(String
newLocation, int numRetries)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
