stephen-shelby commented on code in PR #10002:
URL: https://github.com/apache/iceberg/pull/10002#discussion_r1530535837
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -66,6 +67,9 @@ class GlueTableOperations extends
BaseMetastoreTableOperations {
// same as org.apache.hadoop.hive.metastore.TableType.EXTERNAL_TABLE
// more details:
https://docs.aws.amazon.com/glue/latest/webapi/API_TableInput.html
private static final String GLUE_EXTERNAL_TABLE_TYPE = "EXTERNAL_TABLE";
+ private static final String GLUE_ICEBERG_METADATA_REFRESH_MAX_RETRIES =
+ "iceberg.glue.metadata-refresh-max-retries";
Review Comment:
> @nastra Thanks for your comment. I will parameterize the max-refresh in
`BaseMetastoreTableOperations`. Also, I want to confirm, is the default value
still the default 20?
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -66,6 +67,9 @@ class GlueTableOperations extends
BaseMetastoreTableOperations {
// same as org.apache.hadoop.hive.metastore.TableType.EXTERNAL_TABLE
// more details:
https://docs.aws.amazon.com/glue/latest/webapi/API_TableInput.html
private static final String GLUE_EXTERNAL_TABLE_TYPE = "EXTERNAL_TABLE";
+ private static final String GLUE_ICEBERG_METADATA_REFRESH_MAX_RETRIES =
+ "iceberg.glue.metadata-refresh-max-retries";
Review Comment:
> @nastra Thanks for your comment. I will parameterize the max-refresh in
`BaseMetastoreTableOperations`. Also, I want to confirm, is the default value
still the default 20?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
