viirya commented on code in PR #280:
URL: https://github.com/apache/iceberg-rust/pull/280#discussion_r1529000272


##########
Cargo.toml:
##########
@@ -61,7 +61,7 @@ murmur3 = "0.5.2"
 once_cell = "1"
 opendal = "0.45"
 ordered-float = "4.0.0"
-parquet = "50"
+parquet = "51"

Review Comment:
   I'm not sure why previously parquet version is not consistent with arrow 
version. Different versions could cause errors like:
   
   ```
       = note: `RecordBatch` and `arrow_array::record_batch::RecordBatch` have 
similar names, but are actually distinct types                                  
                                                                           
   note: `RecordBatch` is defined in crate `arrow_array`                        
                                      
      --> 
/Users/liangchi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-50.0.0/src/record_batch.rs:72:1
                                                                                
                                
       |                                                                        
                                      
   72  | pub struct RecordBatch {                                               
                                      
       | ^^^^^^^^^^^^^^^^^^^^^^                           
   note: `arrow_array::record_batch::RecordBatch` is defined in crate 
`arrow_array`                                   
      --> 
/Users/liangchi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-51.0.0/src/record_batch.rs:72:1
                                                                                
                                
       |                                                                        
                                                                                
                                                                          
   72  | pub struct RecordBatch {                                               
                                      
       | ^^^^^^^^^^^^^^^^^^^^^^
       = note: perhaps two different versions of crate `arrow_array` are being 
used?
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to