viirya commented on code in PR #280:
URL: https://github.com/apache/iceberg-rust/pull/280#discussion_r1528050445
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -112,20 +103,14 @@ impl<T: LocationGenerator, F: FileNameGenerator>
FileWriterBuilder for ParquetWr
.generate_location(&self.file_name_generator.generate_file_name()),
)?;
let inner_writer = TrackWriter::new(out_file.writer().await?,
written_size.clone());
- let init_buffer_size = max(Self::MIN_BUFFER_SIZE,
self.init_buffer_size);
- let writer = AsyncArrowWriter::try_new(
- inner_writer,
- self.schema.clone(),
- init_buffer_size,
- Some(self.props),
- )
- .map_err(|err| {
- Error::new(
- crate::ErrorKind::Unexpected,
- "Failed to build parquet writer.",
- )
- .with_source(err)
- })?;
+ let writer = AsyncArrowWriter::try_new(inner_writer,
self.schema.clone(), Some(self.props))
Review Comment:
See https://github.com/apache/arrow-rs/pull/5485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
