a-agmon commented on PR #259:
URL: https://github.com/apache/iceberg-rust/pull/259#issuecomment-1996855461
Thank you @liurenjie1024 and @Xuanwo for the comments!
Besides one line break that I can't get the formatter to accept, I believe I
have addressed all comments.
I can also add something like this to this PR if there is an agreement
```rust
/// Consumes the `StaticTable` and return it as a `Table`
/// Please use this method carefully as the Table it returns remains
detached from a catalog
/// and can't be used to perform modifications on the table.
pub fn into_table(self) -> Table {
self.0
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
