a-agmon commented on PR #259: URL: https://github.com/apache/iceberg-rust/pull/259#issuecomment-1994980247
Hi @liurenjie1024 , Thanks much for the comments! I have addressed all issues. For the doctest, I added the tokio-test crate as a dev dependency in order to have an async runtime there for the async code. This seems like the right [approach](https://stackoverflow.com/a/64597248/22560711). It only test compile as I think its a good idea to show an example using S3 even though it can't run. At any rate this flow is unit tested. Hope this is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
