rdblue commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1520419670
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -501,19 +538,17 @@ public <T> Literal<T> to(Type type) {
return (Literal<T>) new TimeLiteral(timeMicros);
case TIMESTAMP:
- if (((Types.TimestampType) type).shouldAdjustToUTC()) {
- long timestampMicros =
- ChronoUnit.MICROS.between(
- EPOCH, OffsetDateTime.parse(value(),
DateTimeFormatter.ISO_DATE_TIME));
- return (Literal<T>) new TimestampLiteral(timestampMicros);
+ final TimestampType tsType = (TimestampType) type;
+ final String value = value().toString();
+ final java.time.temporal.Temporal valueAsTemporal;
+ if (tsType.shouldAdjustToUTC()) {
+ valueAsTemporal =
DateTimeUtil.isoTimestamptzToOffsetDateTime(value);
} else {
- long timestampMicros =
- ChronoUnit.MICROS.between(
- EPOCH,
- LocalDateTime.parse(value(),
DateTimeFormatter.ISO_LOCAL_DATE_TIME)
- .atOffset(ZoneOffset.UTC));
- return (Literal<T>) new TimestampLiteral(timestampMicros);
+ valueAsTemporal =
+
DateTimeUtil.isoTimestampToLocalDateTime(value).atOffset(ZoneOffset.UTC);
}
+ final long timestampUnits = tsType.unit().between(EPOCH,
valueAsTemporal);
Review Comment:
Another issue with using `Unit` is that this is splitting conversion logic
between `DateTimeUtil` and here. It should all move to `DateTimeUtil` and this
should just call `isoTimestamp[tz]ToNanos` or isoTimestamp[tz]ToMicros`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
