jbonofre commented on PR #9884: URL: https://github.com/apache/iceberg/pull/9884#issuecomment-1989002764
@danielcweeks Yeah, it makes sense. To summarize (and be sure I understand well :) ): 1. An user can define his own `org.apache.iceberg.io.FileIO` implementation (let's say `MyFileIO`). 2. The user can define the scheme (let's say `my-fs://...`) via catalog/hadoop properties/conf. At some point, I wonder if it would not be good to flag `ResolvingFileIO` as `@deprecated` to avoid confusion (as it was mostly for transition). Maybe I can reuse this PR to illustrate (with a test) how a custom `FileIO` and scheme can be injected (I see `TestResolvingFileIO` but not `TestFileIO` or similar). I see `CustomFileIO` in Spark `TestWriteAborts` but nothing in "core". Else I will close this PR. Thanks for all details ! Much appreciated ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
