Xuanwo commented on code in PR #241:
URL: https://github.com/apache/iceberg-rust/pull/241#discussion_r1519947613
##########
crates/iceberg/src/scan.rs:
##########
@@ -52,6 +62,18 @@ impl<'a> TableScanBuilder<'a> {
self
}
+ /// Sets the scan as being case-insensitive
+ pub fn with_case_insensitivity(mut self) -> Self {
Review Comment:
This API is a bit strange to me. How about using `with_case_sensitive(v:
bool)` for clear?
##########
crates/iceberg/src/scan.rs:
##########
@@ -207,6 +268,34 @@ impl FileScanTask {
}
}
+/// Evaluates manifest files to see if their partition values comply with a
filter predicate
+pub struct PartitionEvaluator {
+ bound_predicate: BoundPredicate,
+ partition_spec: PartitionSpecRef,
+}
+
+impl PartitionEvaluator {
+ pub(crate) fn new(partition_spec: PartitionSpecRef, bound_predicate:
BoundPredicate) -> Self {
+ PartitionEvaluator {
+ bound_predicate,
+ partition_spec,
+ }
+ }
+
+ pub(crate) fn filter_manifest(&self, _manifest: &Manifest) -> bool {
+ // TODO: filter manifests using partition summaries
Review Comment:
How about leaving a `todo!()` here to avoid we forgot this TODO and leak
this behavior to end users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
