liurenjie1024 commented on PR #241: URL: https://github.com/apache/iceberg-rust/pull/241#issuecomment-1987506207
Hi, @sdd Thanks for this pr. The filtering process in fact consists of two steps: 1. Filter manifest files in manifest list. This step is relative easy to do, and has no dependency, see [python implementation](https://github.com/apache/iceberg-python/blob/ea9da8856a686eaeda0d5c2be78d5e3102b67c44/pyiceberg/table/__init__.py#L827). 2. Implement partition pruning. This step is relative complicated, since it has several dependencies, such as inclusive projections, data file evaluator, you can see [python implementation](https://github.com/apache/iceberg-python/blob/ea9da8856a686eaeda0d5c2be78d5e3102b67c44/pyiceberg/table/__init__.py#L787). My suggestion is to finish [ManifestEvalVisitor](https://github.com/apache/iceberg-python/blob/4ed5a144ecad69878cf47292557b17df31ffe5a8/pyiceberg/expressions/visitors.py#L548) first since it's relative easy and has no dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
