syun64 commented on code in PR #509:
URL: https://github.com/apache/iceberg-python/pull/509#discussion_r1518883984
##########
pyiceberg/manifest.py:
##########
@@ -308,6 +308,7 @@ def data_file_with_partition(partition_type: StructType,
format_version: Literal
field_id=field.field_id,
name=field.name,
field_type=partition_field_to_data_file_partition_field(field.field_type),
+ required=False,
Review Comment:
Sounds good @Fokko . I've made the corresponding change to partition_type to
carry this over from the partition field as suggested 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
