syun64 opened a new pull request, #509: URL: https://github.com/apache/iceberg-python/pull/509
Similar to how the [partition fields are already initialized](https://github.com/apache/iceberg-python/blob/pyiceberg-0.6.x/pyiceberg/partitioning.py#L193) with `required=False` in `partition_type`, we should set `required=False` in the manifest_entry schema within the ManifestFile. This PR introduces this fix first from @jqin61 's WIP PR, so other PRs that add partition values to manifest files can be unblocked. Without this change, we cannot serialize None partition values into the ManifestEntry in the avro file. Below WIP PRs require this change Partitioned Write: https://github.com/apache/iceberg-python/pull/353 Add Files: https://github.com/apache/iceberg-python/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
