nastra commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1515994388
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -468,6 +468,10 @@ private JdbcUtil() {}
static Namespace stringToNamespace(String namespace) {
Preconditions.checkArgument(namespace != null, "Invalid namespace %s",
namespace);
+ if (namespace.isEmpty()) {
Review Comment:
previously this method would return the identifier as `.tblName` instead of
`tblName` when using an empty namespace, because L475 passes an array with a
single empty string to `Namespace.of()`.
I guess the question here is: is `Namespace.of("")` the same as
`Namespace.empty()` and should we maybe fix `Namespace.of()`?
It seems there are currently no existing tests that would indicate what the
correct behavior should be in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
