nastra commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1515818159


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -305,9 +305,12 @@ public List<TableIdentifier> listTables(Namespace 
namespace) {
     }
 
     return fetch(
-        row ->
-            JdbcUtil.stringToTableIdentifier(
-                row.getString(JdbcUtil.TABLE_NAMESPACE), 
row.getString(JdbcUtil.TABLE_NAME)),
+        row -> {
+          String ns = row.getString(JdbcUtil.TABLE_NAMESPACE);

Review Comment:
   previously this would return the identifier as `.tblName` instead of 
`tblName` when using an empty namespace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to