hiloboy0119 commented on code in PR #8409:
URL: https://github.com/apache/iceberg/pull/8409#discussion_r1515373674


##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -90,6 +94,15 @@ public Boolean struct(
               Types.NestedField field = fields.get(pos);
               if (isMissing) {
                 addColumn(partnerId, field);

Review Comment:
   @amogh-jahagirdar This is the core problem with the existing code.  
Additional columns, no matter where they are in the schema are just added.  
This always adds them to the end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to