himadripal commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1504898529
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkShufflingDataRewriter.java:
##########
@@ -86,6 +88,16 @@ protected SparkShufflingDataRewriter(SparkSession spark,
Table table) {
protected abstract org.apache.iceberg.SortOrder sortOrder();
+ /**
+ * Retrieves and returns the schema for the rewrite using the current table
schema.
Review Comment:
Took another lookI think, we need to keep this method,
`SparkZOrderDataRewriter` `sortSchema()` need all Z_SCHEMA columns added
explicitly. Used in
`org.apache.iceberg.spark.actions.SparkShufflingDataRewriter#outputSortOrder`-
this method is common for `SparkZOrderDataRewriter` and
`SparkBinPackDataRewriter`
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkShufflingDataRewriter.java:
##########
@@ -86,6 +88,16 @@ protected SparkShufflingDataRewriter(SparkSession spark,
Table table) {
protected abstract org.apache.iceberg.SortOrder sortOrder();
+ /**
+ * Retrieves and returns the schema for the rewrite using the current table
schema.
Review Comment:
Took another look,I think, we need to keep this method,
`SparkZOrderDataRewriter` `sortSchema()` need all Z_SCHEMA columns added
explicitly. Used in
`org.apache.iceberg.spark.actions.SparkShufflingDataRewriter#outputSortOrder`-
this method is common for `SparkZOrderDataRewriter` and
`SparkBinPackDataRewriter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
