Fokko commented on code in PR #466:
URL: https://github.com/apache/iceberg-python/pull/466#discussion_r1507438784
##########
pyiceberg/catalog/rest.py:
##########
@@ -156,8 +156,10 @@ class RegisterTableRequest(IcebergBaseModel):
class TokenResponse(IcebergBaseModel):
access_token: str = Field()
token_type: str = Field()
- expires_in: int = Field()
- issued_token_type: str = Field()
+ expires_in: Optional[int] = Field(default=None)
+ issued_token_type: Optional[str] = Field(default=None)
Review Comment:
We could also convert this into a literal, since it is an enum in the spec:
```suggestion
issued_token_type:
Optional[Literal['urn:ietf:params:oauth:token-type:access_token',
'urn:ietf:params:oauth:token-type:refresh_token',
'urn:ietf:params:oauth:token-type:id_token',
'urn:ietf:params:oauth:token-type:saml1',
'urn:ietf:params:oauth:token-type:saml2',
'urn:ietf:params:oauth:token-type:jwt'] = Field(default=None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
