syun64 commented on code in PR #466:
URL: https://github.com/apache/iceberg-python/pull/466#discussion_r1504619419
##########
pyiceberg/catalog/rest.py:
##########
@@ -156,8 +156,10 @@ class RegisterTableRequest(IcebergBaseModel):
class TokenResponse(IcebergBaseModel):
access_token: str = Field()
token_type: str = Field()
- expires_in: int = Field()
- issued_token_type: str = Field()
+ expires_in: Optional[int] = None
+ issued_token_type: Optional[str] = None
+ refresh_token: Optional[str] = None
+ scope: Optional[str] = None
Review Comment:
This is a nit, could we use Field annotation like the attributes above?
[Example](https://github.com/apache/iceberg-python/blob/5209874cd4685427520b67b64188f5e9919f2816/pyiceberg/table/snapshots.py#L141)
```suggestion
expires_in: Optional[int] = Field(default=None)
issued_token_type: Optional[str] = Field(default=None)
refresh_token: Optional[str] = Field(default=None)
scope: Optional[str] = Field(default=None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
