BsoBird commented on code in PR #9546:
URL: https://github.com/apache/iceberg/pull/9546#discussion_r1505220977
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -234,7 +254,7 @@ public long newSnapshotId() {
}
@VisibleForTesting
- Path getMetadataFile(int metadataVersion) throws IOException {
+ Path getMetadataFile(Integer metadataVersion) throws IOException {
Review Comment:
@RussellSpitzer
Because when Mokito proxy executes a method, the parameter cannot be a basic
type, otherwise it will report an error.
Therefore, if we don't want to test this method, we either need to adjust
its input type to a non-basic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
