rdblue commented on code in PR #9787:
URL: https://github.com/apache/iceberg/pull/9787#discussion_r1501169076
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -138,13 +138,13 @@ public boolean dropTable(TableIdentifier tableIdentifier,
boolean purge) {
@Override
public List<TableIdentifier> listTables(Namespace namespace) {
- if (!namespaceExists(namespace) && !namespace.isEmpty()) {
+ if (!namespaceExists(namespace)) {
Review Comment:
I don't think we want to change the behavior here. And if we did, how is
this more correct?
I think it is fine for catalogs to consider this an independent namespace.
And in this case, it makes sense that the root namespace always exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
