nastra commented on PR #9787: URL: https://github.com/apache/iceberg/pull/9787#issuecomment-1961965465
@rdblue I've split this into two commits. In the first commit you can see that once the behavior in `InMemoryCatalog` is fixed, running `SHOW VIEWS` or `SHOW VIEWS in <catalog>` fails as expected as can be seen in the `showViewsWithoutNamespace()` test. The second commit then fixes the behavior in Spark and updates `showViewsWithoutNamespace()` so that all of these commands now work without specifying the namespace. That being said, it makes sense to review each commit individually to see the behavioral changes. When merging, I think it makes sense to keep the 2 commits separate. Alternatively I can split this into two PRs, but that would require additional CI cycles & rebases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
