dramaticlly commented on code in PR #9724: URL: https://github.com/apache/iceberg/pull/9724#discussion_r1496319649
########## api/src/main/java/org/apache/iceberg/RemoveDanglingDeletesMode.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.Locale; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Enum of supported remove dangling deletes mode, it defines the mode in which the dangling delete + * files shall be pruned + * + * <p> + * + * <ul> + * <li>If remove-dangling-deletes=metadata, then dangling delete files will be pruned from iceberg + * metadata. Pruning apply to both position delete and equality delete files. + * <li>If remove-dangling-deletes=none, then pruning is disabled. + * </ul> + * + * <p> + */ +public enum RemoveDanglingDeletesMode { + METADATA("metadata"), + NONE("none"); + + private final String mode; + + RemoveDanglingDeletesMode(String modeName) { + this.mode = modeName; + } + + public String modeName() { + return mode; + } + + public static RemoveDanglingDeletesMode fromName(String modeName) { + String errorMessage = "Invalid remove dangling deletes mode name: %s"; + Preconditions.checkArgument(modeName != null, String.format(errorMessage, "null")); + // Replace the hyphen in order name with underscore to map to the enum value. For example: + // rewrite-position to REWRITE_POSITION + try { + return RemoveDanglingDeletesMode.valueOf( Review Comment: yes you are right. Initially i though add `rewrite-position` so that we can trigger rewrite position deletes spark action but removed later. I guess I can remove it now and add it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
