dramaticlly commented on code in PR #9724: URL: https://github.com/apache/iceberg/pull/9724#discussion_r1489817653
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -99,6 +99,20 @@ public interface RewriteDataFiles boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true; + /** + * Removes dangling delete files from current snapshot after compaction. A delete file is + * considered dangling if it does not apply to any non-expired data file. Review Comment: Yes, I should reword to `Delete dangling delete files from current snapshot after compaction` instead. As @manuzhang point out, this will stop track dangling delete files from iceberg metadata. To remove file from filesystem, it's always handled by expire snapshot and remove orphans action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
