rdblue commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1495005890
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2513,6 +2536,7 @@ components:
- $ref: '#/components/schemas/RemovePropertiesUpdate'
- $ref: '#/components/schemas/SetStatisticsUpdate'
- $ref: '#/components/schemas/RemoveStatisticsUpdate'
+ - $ref: '#/components/schemas/AppendDataFilesUpdate'
Review Comment:
I don't think that this should be part of the table update API and should be
a separate endpoint instead.
The table API commits to the table every time it is called, but I think that
the value of an API that can post new data files is that you don't necessarily
need to commit every time. One of the main use cases for this feature is to be
able to produce data files in parallel and commit them in groups, with the
catalog handling the coordination to keep track of the files and eventually
commit them to the table. I don't see how the update proposed here would be
useful for that purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
