rdblue commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1494994843


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,97 @@ components:
           type: integer
           format: int64
 
+    TypeValue:
+      oneOf:
+        - $ref: '#/components/schemas/PrimitiveTypeValue'

Review Comment:
   +1 for option 1.
   
   I also 
[commented](https://github.com/apache/iceberg/pull/9695#pullrequestreview-1889027020)
 on #9695 about the non-primitive types. I think that structs should use a 
simple array of these primitive values.
   
   @jackye1995, should we move these additions to a separate PR so that the 
scan APIs are not blocked by the append API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to